Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1. support long press like flutter #23

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

1. support long press like flutter #23

wants to merge 26 commits into from

Conversation

imiskolee
Copy link

@imiskolee imiskolee commented May 27, 2021 •
edited
Loading

What's this PR doing ?

#1. added new mouse event callback on DisplayObject called onLongPress.

how the new event longPress happed ?

yourdisplayobject.longPressDuration = Duration(seconds: 1.0);
yourdisplayobject.longPressDistance = 1.0;
yourdisplayobject.onLongPress((event){});

IsmailAlamKhan and others added 16 commits March 7, 2021 04:47
@IsmailAlamKhan
Migrated to null safety and made another branch
bf89458
@IsmailAlamKhan
fixed the graphx_widget for the null_check operator error
0b79ae9
@shariful2011
another small fix for the graphx_widget converter
b951329
@IsmailAlamKhan
removed the trace when calling ContextUtils.getRenderObjectBounds
b512710
@IsmailAlamKhan
Fix for the GText conflict
14f393c
@IsmailAlamKhan
Another fix for GText confilct
0f7662d
@IsmailAlamKhan
same as previous commit
6550a9e
@IsmailAlamKhan
same as before
e416dbc
@IsmailAlamKhan
Merge branch 'master' into null-safety
9edd3f9
@IsmailAlamKhan
added the gtween addition
778fe9b
@IsmailAlamKhan
fixed the duplicate prop on text
45292fc
@roipeker
Merge pull request roipeker#15 from IsmailAlamKhan/null-safety
d86e186 
Null safety, thanks to @IsmailAlamKhan
@IsmailAlamKhan
migrated the examples to null-safety
c75233b
@roipeker
critical fixes for null-safety.
bc12fda 
-several core fixes for null-safety.
-fixed the non-working examples.
-added some comments in the README.
-increased the version.
@roipeker
Merge pull request roipeker#20 from IsmailAlamKhan/null-safety
5eb611f 
Migrated the examples to null-safety
@roipeker
Update graphics.dart
2bb46ec 
- fixes an error in `Graphics.drawPoly()`.
@roipeker
Copy link
Owner

First of all, thanks for the PR!
As GraphX originally tries to adapt to the ActionScript experience, I have some doubts regarding this type of computed gestures should be in an external decorator class. As multitouch input is also missing, might be an interesting feature to revisit how this works.

Regarding the longPress signal, it would be great to be able to configure the threshold distance and duration, on demand, how do think that should look like?

@imiskolee
Copy link
Author

@roipeker Yes, we need configurable the duration and test distance. Maybe configure them on displayobject or others ?

@roipeker
Copy link
Owner

Might be. Although Im still unsure about the addition on DisplayObject for this "compound" gesture... as you might as well create a mixin, or extension to add this behavior on top of the current input signals for your specific objects. Too bad that we should stay "idiomatic" with the Signal callbacks, otherwise something like onLongPress(timeout, distance).add(callback) would be an interesting option to not bloat so much the current loong api available in displayObject.

@imiskolee
Copy link
Author

@roipeker yes, I am also think onLongPress(timeout, distance).add(callback) it's better solution. I will try it next a few days.

@imiskolee
Copy link
Author

Hello, I am already finished it.

@imiskolee
Copy link
Author

And more, I will start to multi-touch event next, did you have any ideas?

@roipeker
Copy link
Owner

No idea in particular to be honest. Might start from stage for the basics events: down, move, release for each touch id

roipeker
roipeker reviewed Jun 1, 2021
View reviewed changes
Copy link
Owner

@roipeker roipeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check the comments and give me your thoughts

lib/src/events/signal.dart Outdated Show resolved Hide resolved
lib/src/events/signal.dart Outdated
EventSignal();
factory EventSignal.longPress(Duration duration,double distance) {
var signal = EventSignal<T>();
signal.configure[EventSignalConfKey.LongPressDuration] = duration;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another observation, even if the Duration type makes total sense in Dart/Flutter, GraphX is currently using double to express durations in the tween system and the "ticker" elapsed time since last frame ... ( 0.1 = 100 milliseconds). Just a thought, as that concept is taken from JS/AS3.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Duration is better on user side, maybe we can translate Duration to double ticks?

lib/src/events/mixins.dart Outdated Show resolved Hide resolved
Misko Lee and others added 2 commits June 1, 2021 18:08
1. keep event signal stateless.
bb5dd6f
Merge remote-tracking branch 'origin/null-safety' into add-long-press…
2ce2f3e 
…-support

# Conflicts:
#	CHANGELOG.md
#	README.md
#	example/lib/demos/simple_interactions/ui/my_button.dart
#	example/pubspec.yaml
#	example/readme.md
#	lib/src/display/display_object.dart
#	lib/src/events/mixins.dart
#	lib/src/render/graphics.dart
#	lib/src/tween/src/mixins/tweenable.dart
#	pubspec.lock
#	pubspec.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roipeker roipeker roipeker left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@imiskolee @roipeker @IsmailAlamKhan @shariful2011