Update Wails to latest version to fix webkit2gtk issue, update to go 1.16 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just ran this on Windows and found another issue. The Wails change to fix Webkit also broke Windows due to differences in strict mode with IE. I just created a PR to wails to resolve that: wailsapp/wails#669 and I will update this PR with the newest version of Wails once that gets merged if this is still open. |
|
Wails PR is merged and released. Linux and Windows builds should both be good now. |
|
@rogchap Any chance you could take a look at this when you have some time so we can get builds fixed on Linux? |
rogchap
approved these changes
Apr 18, 2021
|
Could we get a release tagged with this fix please? It would help updating the Archlinux package :-) |
ttys3
added a commit
to ttys3/optimus
that referenced
this pull request
Jun 26, 2021
ttys3
added a commit
to ttys3/optimus
that referenced
this pull request
Jun 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #54
I updated Wails to the latest version to address this issue caused by a change in a new version of webkit2gtk. I was also having an issue where the UI wasn't showing up at all which I think is related to this other Wails issue related to Mewn. Mewn is now deprecated and the approach Wails is taking is to replace Mewn with Go 1.16's native embedding functionality so that's the approach I followed here too.
Let me know if you need me to change anything, thanks!