Run v8 python script in a separate subshell #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is how it is run in v8, so we shouldn't depend on it being importable
Codecov Report
@@ Coverage Diff @@
## master #228 +/- ##
=======================================
Coverage 95.86% 95.86%
=======================================
Files 17 17
Lines 580 580
=======================================
Hits 556 556
Misses 15 15
Partials 9 9 Continue to review full report at Codecov.
|
genevieve
approved these changes
Nov 11, 2021
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
build/deps.py was trying to import a script from v8, in a way that isn't python3 compatible, since there aren't init.py files in the directories on the path to the script
Solution
Use a separate command to execute the script, which is the way this is done in v8 as well (https://github.com/v8/v8/blob/ee74e718339223345b42935e9f4cbc7be208e557/DEPS#L552-L558).