Fix mismatched C free of memory allocated with C++ new #220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There were a couple of places where C++
new
was used in v8go.cc, then C.free was used on that pointer in Go.Mixing these is technically undefined behaviour, even though
new
anddelete
is often implemented as a wrapper aroundmalloc
andfree
Solution
I used
malloc
to allocate these values so they can be safely freed usingC.free
.Looks like clang-format was missed on the existing code in master, so using that produced some more noise to this change, but I isolated that to the second commit in this PR