Changes the opt-out character from _ to # #151
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change
This change is needed since we might have collisions with internal modules in Node otherwise, as seen here.
An example where this is a problem is in
browserify-zlib
that has the following code:Roc will in some instances process this code through its resolver and the following branch will be true.
This means that the code will now try to require
stream_transform
instead of the correct_stream_transform
. This will then result in an error since this module does not exist.This change means that opting out now is done in the following way.
Question
Is the
#
a good character to use for opt-out? Is there a better alternative that we can use?