Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MetafieldService.php and fix bugs. #21

Closed
wants to merge 4 commits into from

Conversation

lyongdee
Copy link

@lyongdee lyongdee commented Jun 1, 2018

1、Add contact_email and total_price_usd to OrderFields.php;
2、Modify cancelled_at type in OrderFields.php;
3、Add OrderFields.php;
4、Fix In MetafieldFields.php line 11: syntax error, unexpected 'NAMESPACE' (T_NAMESPACE), expecting identifier (T_STRING)

@robwittman
Copy link
Owner

@lyongdee I made a few changes to master that caused merge conflicts. In the interest of expediency, I opened a new PR against master and added your changes, which has been merged.

Apologies for the delay, and thanks a bunch for putting this together. It should be available in 2.3.* soon

@robwittman robwittman closed this Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants