Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config parser fails when name of tun device is tunnel #43

Closed
whohoho opened this issue Mar 29, 2020 · 1 comment · Fixed by #86
Closed

config parser fails when name of tun device is tunnel #43

whohoho opened this issue Mar 29, 2020 · 1 comment · Fixed by #86
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@whohoho
Copy link
Contributor

whohoho commented Mar 29, 2020

example here:
whohoho@c37d7a1
@hannesm hannesm mentioned this issue Mar 31, 2020
Closed
8 tasks
@hannesm hannesm added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels Mar 31, 2020
@hannesm
Copy link
Contributor

hannesm commented Mar 31, 2020

Thanks for the report, this is something we should fix (and add a regression test to the repository).

@hannesm hannesm removed the enhancement New feature or request label Apr 1, 2020
@hannesm hannesm mentioned this issue Oct 4, 2023
Closed
hannesm added a commit that referenced this issue Oct 4, 2023
@hannesm
Config parser: allow dev tun<any string>, as in 'dev tunnel' or 'dev …
3020b63 
…tunmir'

Previously, only tun<numeric> (with numeric in range 0..128) was allowed, which
lead to issues. In the end, the dev-type is `Tun if the name starts with 'tun',
and `Tap if the name starts with 'tap' -- otherwise the 'dev-type' has to be
specified.

Fixes #43 #85
@hannesm hannesm mentioned this issue Oct 4, 2023
Merged
@reynir reynir closed this as completed in #86 Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Config parser: allow dev tun<any string>, as in 'dev tunnel' or 'dev tunmir' robur-coop/miragevpn
2 participants
@hannesm @whohoho