Add icub-firmware-build to icub-head profile #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI fails as the PRs still need to be merged. |
Nicogene
approved these changes
Dec 20, 2023
|
probably we can retry to run again the CI |
We probably need to wait for icub-firmware release, or have some temporary hack. |
|
@Nicogene do you think we can have some buffer time between the icub-firmware-build release and the distro release? So we can have the time to integrate this PR. |
|
@davidetome I forgot to mention you back in time, just for your information after this PR (that we can merge once robotology/icub-firmware-build#124 is release) the icub-firmware-build files will be present in the superbuild automatically. |
d4d88a3
to
e0b5c34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires that the following PRs are merged and released:
This PR adds the
icub-firmware-buildas a repository that is cloned and installed with the icub-head, to simplify the process of downloading the firmware corresponding to a given distro release.A first problem that I noticed is that while the size of firmware itself is quite limited (~4 MB for all files), the repo is quite heavy to download (~250 MB), due to the size of the whole history of icub-firmware-build binaries. To reduce the burden for existing robotology-superbuild users, for the first time for this project we pass the
GIT_SHALLOWoption, so that a shallow clone is performed while cloning the repo (hence the modifications in robotology/ycm-cmake-modules#440). Unfortunately, CMake's GIT_SHALLOW is not actually shallow (see https://gitlab.kitware.com/cmake/cmake/-/issues/17770), but even if it is not a strictly shallow clone, passingGIT_SHALLOWthe repo clone size reduced from 250 MB to 60 MB, so I think it is a worth improvement.This PR also fixes half of #863 .