Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a
while True
in the library is scary. I have had infinite loops when I have a special bad panorama ID.Normal non-existent ID points to an url that's requestable, but gives back bad data, which causes the program to error out on the image parsing exception. There are also a few special bad ID that straight cannot be requested, and the program will keep trying til the end of the world. I don't have example IDs in hand at the moment, but please trust me on this. My guess is that these ID exists but are unpublished by Google due to whatever reason.
I'm suggesting to enforce a default
max_retries
of 6 for the download functions, and also make it to be user configurable.