Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give error if running unsupported version of 6S #87

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

robintw
Copy link
Owner

@robintw robintw commented Jun 8, 2021

Fixes #31.

@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #87 (d64fdfc) into master (173501a) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   87.75%   87.71%   -0.05%     
==========================================
  Files          18       18              
  Lines        1715     1717       +2     
==========================================
+ Hits         1505     1506       +1     
- Misses        210      211       +1     
Impacted Files Coverage Δ
Py6S/sixs.py 95.00% <50.00%> (-0.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 173501a...d64fdfc. Read the comment docs.

@robintw robintw merged commit 45a6e98 into master Jun 8, 2021
@robintw robintw deleted the error-on-wrong-version branch June 8, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Py6S should raise an exception when used with the wrong version of 6S
1 participant