cleanup hash_supported_argument feature flag (2/2)

Reviewed By: tyao1 Differential Revision: D46766361 fbshipit-source-id: 02bb1550172ab356174ba286f9878473a6fc2b0e
robinpokorny · Jun 20, 2023 · 20ff678 · 20ff678
1 parent bc40b4b
commit 20ff678
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 8 deletions.
diff --git a/compiler/crates/common/src/feature_flags.rs b/compiler/crates/common/src/feature_flags.rs
@@ -27,11 +27,6 @@ pub struct FeatureFlags {
  #[serde(default)]
  pub relay_resolver_enable_output_type: FeatureFlag,
 
- /// Enable hashing of the `supported` argument of 3D fields. Partial
- /// enabling of the feature flag checks the name based on the field type.
- #[serde(default)]
- pub hash_supported_argument: FeatureFlag,
-
  /// For now, this also disallows fragments with variable definitions
  /// This also makes @module to opt in using @no_inline internally
  /// NOTE that the presence of a fragment in this list only controls whether a fragment is *allowed* to

diff --git a/compiler/crates/relay-compiler-playground/__tests__/relay_compiler_playground-test.js b/compiler/crates/relay-compiler-playground/__tests__/relay_compiler_playground-test.js
@@ -139,7 +139,7 @@ describe('Err', () => {
  );
  expect(actual.Err).toEqual({
  ConfigError:
- 'unknown field `this_key_does_not_exist`, expected one of `enable_flight_transform`, `enable_relay_resolver_transform`, `hash_supported_argument`, `no_inline`, `enable_3d_branch_arg_generation`, `actor_change_support`, `text_artifacts`, `enable_provided_variables`, `skip_printing_nulls`, `enable_fragment_aliases` at line 1 column 26',
+ 'unknown field `this_key_does_not_exist`, expected one of `enable_flight_transform`, `enable_relay_resolver_transform`, `no_inline`, `enable_3d_branch_arg_generation`, `actor_change_support`, `text_artifacts`, `enable_provided_variables`, `skip_printing_nulls`, `enable_fragment_aliases` at line 1 column 26',
  });
  });
  test('parse_to_ast', () => {

diff --git a/compiler/crates/relay-compiler/tests/compile_relay_artifacts/mod.rs b/compiler/crates/relay-compiler/tests/compile_relay_artifacts/mod.rs
@@ -100,7 +100,6 @@ pub fn transform_fixture(fixture: &Fixture<'_>) -> Result<String, String> {
  ];
 
  let feature_flags = FeatureFlags {
- hash_supported_argument: FeatureFlag::Enabled,
  // test SplitOperations that do not use @no-inline D28460294
  no_inline: FeatureFlag::Limited {
  allowlist: no_inline_allowlist.into_iter().collect(),

diff --git a/compiler/crates/relay-compiler/tests/compile_relay_artifacts_with_custom_id/mod.rs b/compiler/crates/relay-compiler/tests/compile_relay_artifacts_with_custom_id/mod.rs
@@ -83,7 +83,6 @@ pub fn transform_fixture(fixture: &Fixture<'_>) -> Result<String, String> {
  let program = Program::from_definitions(Arc::clone(&schema), ir);
 
  let feature_flags = FeatureFlags {
- hash_supported_argument: FeatureFlag::Disabled,
  no_inline: FeatureFlag::Enabled,
  enable_relay_resolver_transform: true,
  enable_3d_branch_arg_generation: true,