Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to issue #175 but I also did some more work, sorry I couldnt resist 😇
getSelectedLines
:location.hash
will always return string so no need the optional channinghighlightLines
:getSelectedLines
will always return array and already check thelocation.hash
before so I replaced that if and add some deconstruct assignment, just small changes to reduce some linessetAttribute/removeAttribute
fortoggleAttribute
with force parameter, just small change to reduce some linesscrollToLine
to scroll to the highlighted linesit unfortunatelly "needs" the
setTimeout
in order to always get fired, otherwise it will only works for a new page load (not for refresh). It does works better having it.watchForShiftClick
to disable native click ongo to top
to prevent it to remove the currently highlighted linesasync/await
from DOMContentLoaded as it is not needed