Skip to content

Commit

Permalink
Fix initializing binding outside the app zone
Browse files Browse the repository at this point in the history
  • Loading branch information
robertodoering committed Jul 8, 2023
1 parent 328e6b4 commit 41af6b7
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 30 deletions.
23 changes: 8 additions & 15 deletions lib/core/misc/error_handler.dart
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ import 'package:shared_preferences/shared_preferences.dart';
/// information about error reporting in Flutter.
class ErrorHandler with LoggerMixin {
ErrorHandler({
required Widget child,
required SharedPreferences sharedPreferences,
required Future<Widget> Function() builder,
}) {
if (kReleaseMode) {
// override the error widget in release mode (the red error screen)
Expand All @@ -35,18 +34,16 @@ class ErrorHandler with LoggerMixin {

runZonedGuarded(
() async {
if (kReleaseMode && sentryDns.isNotEmpty) {
await SentryFlutter.init(
(options) => options.dsn = sentryDns,
).handleError(logErrorHandler);
}

runApp(child);
WidgetsFlutterBinding.ensureInitialized();
sharedPreferences = await SharedPreferences.getInstance();
runApp(await builder());
},
(e, st) => _handleError(e, st, sharedPreferences: sharedPreferences),
_handleError,
);
}

late final SharedPreferences sharedPreferences;

/// Handles errors caught by the Flutter framework.
///
/// Forwards the error to the [_handleError] handler when in release mode.
Expand All @@ -68,11 +65,7 @@ class ErrorHandler with LoggerMixin {
}

/// Prints the error and reports it to sentry in release mode.
Future<void> _handleError(
Object error,
StackTrace stackTrace, {
required SharedPreferences sharedPreferences,
}) async {
Future<void> _handleError(Object error, StackTrace stackTrace) async {
if (error is SocketException) {
// no internet connection, can be ignored
log.warning(
Expand Down
31 changes: 16 additions & 15 deletions lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -16,23 +16,24 @@ import 'package:shared_preferences/shared_preferences.dart';
/// `--dart-define=twitter_consumer_key=your_consumer_key` and
/// `--dart-define=twitter_consumer_secret=your_consumer_secret`.
Future<void> main() async {
WidgetsFlutterBinding.ensureInitialized();
final sharedPreferences = await SharedPreferences.getInstance();

// pre-cache flare animations
FlareCache.doesPrune = false;
await warmupFlare();

// ErrorHandler will run the app and handle uncaught errors
ErrorHandler(
sharedPreferences: sharedPreferences,
child: ProviderScope(
overrides: [
sharedPreferencesProvider.overrideWithValue(sharedPreferences),
],
observers: [ProviderLogger()],
child: const HarpyApp(),
),
builder: () async {
WidgetsFlutterBinding.ensureInitialized();
final sharedPreferences = await SharedPreferences.getInstance();

// pre-cache flare animations
FlareCache.doesPrune = false;
await warmupFlare();

return ProviderScope(
overrides: [
sharedPreferencesProvider.overrideWithValue(sharedPreferences),
],
observers: [ProviderLogger()],
child: const HarpyApp(),
);
},
);
}

Expand Down

0 comments on commit 41af6b7

Please sign in to comment.