parser/lexer: correct ID_Start & ID_Continue checks #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenh
requested changes
Jun 10, 2024
filips
force-pushed
the
lexer-unicode-start-continue
branch
from
fc0cdaf
to
a14eb3c
Compare
I added a few tests for the areas where the allowed character sets differ. Please let me know if you want me to add further tests. |
filips
force-pushed
the
lexer-unicode-start-continue
branch
from
a14eb3c
to
c1a6c0a
Compare
|
@stevenh Linter warnings should be fixed now |
stevenh
requested changes
Jun 11, 2024
parser/lexer.go
Outdated
| unicode.Pattern_White_Space, | ||
| } | ||
|
|
||
| func UnicodeIDStart(r rune) bool { |
There was a problem hiding this comment.
Just a minor tweak can we unexport these:
Suggested change
| func UnicodeIDStart(r rune) bool { | |
| func unicodeIDStart(r rune) bool { |
parser/lexer.go
Outdated
| return unicode.In(r, includeIDStart...) | ||
| } | ||
|
|
||
| func UnicodeIDContinue(r rune) bool { |
There was a problem hiding this comment.
Suggested change
| func UnicodeIDContinue(r rune) bool { | |
| func unicodeIDContinue(r rune) bool { |
parser/lexer.go
Outdated
| func isDigit(chr rune, base int) bool { | ||
| return digitValue(chr) < base | ||
| } | ||
|
|
||
| func isIdentifierStart(chr rune) bool { | ||
| return chr == '$' || chr == '_' || chr == '\\' || | ||
| 'a' <= chr && chr <= 'z' || 'A' <= chr && chr <= 'Z' || | ||
| chr >= utf8.RuneSelf && unicode.IsLetter(chr) | ||
| chr >= utf8.RuneSelf && UnicodeIDStart(chr) |
There was a problem hiding this comment.
Suggested change
| chr >= utf8.RuneSelf && UnicodeIDStart(chr) | |
| chr >= utf8.RuneSelf && unicodeIDStart(chr) |
parser/lexer.go
Outdated
| } | ||
|
|
||
| func isIdentifierPart(chr rune) bool { | ||
| return chr == '$' || chr == '_' || chr == '\\' || | ||
| 'a' <= chr && chr <= 'z' || 'A' <= chr && chr <= 'Z' || | ||
| '0' <= chr && chr <= '9' || | ||
| chr >= utf8.RuneSelf && (unicode.IsLetter(chr) || unicode.IsDigit(chr)) | ||
| chr >= utf8.RuneSelf && UnicodeIDContinue(chr) |
There was a problem hiding this comment.
Suggested change
| chr >= utf8.RuneSelf && UnicodeIDContinue(chr) | |
| chr >= utf8.RuneSelf && unicodeIDContinue(chr) |
filips
force-pushed
the
lexer-unicode-start-continue
branch
from
c1a6c0a
to
8237717
Compare
Sure thing, I pushed with the methods unexported |
stevenh
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unicode.IsLetterandunicode.IsDigitwill not return the complete set ofID_StartandID_Continuecharacters defined here: https://www.unicode.org/reports/tr31/.