Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ast: ThisExpression.Idx1() should point to the end of this #251

Merged
merged 1 commit into from
Jun 2, 2017
Merged

ast: ThisExpression.Idx1() should point to the end of this #251

merged 1 commit into from
Jun 2, 2017

Conversation

kalbasit
Copy link
Contributor

@kalbasit kalbasit commented May 13, 2017 •
edited by stevenh
Loading

Fixed the ast position of ThisExpression.

stevenh
stevenh requested changes Jun 1, 2017
View reviewed changes
Copy link
Collaborator

@stevenh stevenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test to show the issue and prove this is the correct fix please.

@kalbasit
Copy link
Contributor Author

kalbasit commented Jun 2, 2017

@stevenh PTAL

@stevenh stevenh merged commit bc4cd51 into robertkrimen:master Jun 2, 2017
@kalbasit kalbasit deleted the fix_this_idx1 branch June 2, 2017 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenh stevenh stevenh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kalbasit @stevenh