-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make use of new "Async" RPC #13
base: 3.x
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.x #13 +/- ##
============================================
- Coverage 80.15% 80.00% -0.16%
- Complexity 52 54 +2
============================================
Files 6 6
Lines 126 130 +4
============================================
+ Hits 101 104 +3
- Misses 25 26 +1 ☔ View full report in Codecov by Sentry. |
@L3tum Could you please fix the test here as well? |
Hey @rustatian , so sorry for the late update, I didn't expect there to be an issue here and even forgot it wasn't merged yet^^ |
This is a follow-up PR for roadrunner-php/goridge#22 implementing the new "async" RPC calls in the Metrics class.
It may be an option to instead modify theMetricsFactory
to return anAsyncMetrics
class instead if it detects an async RPC interface, or something like that. Please lmk if you'd like me to change that. Once the implementation is good to go I'll add tests for it as well.EDIT: I've switched to the
MetricsFactory
because implementing it into our service was kinda weird otherwise. I've also added a few tests and fixed the Psalm complaint.For further info please read the linked PR in the goridge repo.
Same PR in the KV repo: roadrunner-php/kv#36