feat: Make use of new "Async" RPC

[L3tum]

Q	A
Bugfix?	❌
Breaks BC?	❌
New feature?	✔️ TODO: please update "Other Features" section in CHANGELOG.md file
Issues	roadrunner-php/goridge#22
Docs PR	spiral/docs#...

This is a follow-up PR for roadrunner-php/goridge#22 implementing the new "async" RPC calls in the Metrics class.
It may be an option to instead modify the MetricsFactory to return an AsyncMetrics class instead if it detects an async RPC interface, or something like that. Please lmk if you'd like me to change that. Once the implementation is good to go I'll add tests for it as well.

EDIT: I've switched to the MetricsFactory because implementing it into our service was kinda weird otherwise. I've also added a few tests and fixed the Psalm complaint.

For further info please read the linked PR in the goridge repo.

Same PR in the KV repo: roadrunner-php/kv#36

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 80.00%. Comparing base (b66eb13) to head (c64ee74).
Report is 1 commits behind head on 3.x.

❗ Current head c64ee74 differs from pull request most recent head 98a70ba

Please upload reports for the commit 98a70ba to get more accurate results.

Files	Patch %	Lines
src/Metrics.php	88.88%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                3.x      #13      +/-   ##
============================================
- Coverage     80.15%   80.00%   -0.16%     
- Complexity       52       54       +2     
============================================
  Files             6        6              
  Lines           126      130       +4     
============================================
+ Hits            101      104       +3     
- Misses           25       26       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rustatian]

@L3tum Could you please fix the test here as well?

[L3tum]

Hey @rustatian , so sorry for the late update, I didn't expect there to be an issue here and even forgot it wasn't merged yet^^
@msmakouz I've updated it so far, however the static analysis complains about a missing type for a constant. Class constant types have only been supported since PHP8.3, while this library (rightfully) doesn't require it and thus doesn't support it. I don't want to mess with these settings without your confirmation, so please let me know how you'd like to resolve that.