Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update setup #227

Merged
merged 22 commits into from
May 16, 2022
Merged

Update setup #227

merged 22 commits into from
May 16, 2022

Conversation

LuckyPigeon
Copy link
Collaborator

@LuckyPigeon LuckyPigeon commented Mar 25, 2022 •
edited
Loading

fix #226

Description

setup.py hasn't update for a long time, so we needs some update as well. Include clean up requiremnents-*.txt and update setup related information.

Solution

Refer to scrapy's setup.py, update our setup.py to latest version, remove redundant requirements files.

Recommend test with tox.ini

@LuckyPigeon LuckyPigeon requested a review from Germey March 25, 2022 08:48
@LuckyPigeon LuckyPigeon requested a review from rmax March 26, 2022 09:01
@LuckyPigeon LuckyPigeon requested review from Germey and removed request for Germey April 9, 2022 07:10
LuckyPigeon and others added 12 commits April 9, 2022 15:15
@LuckyPigeon
Update .gitignore & LICENSE (rmax#225)
98f0ff4 
* update .gitignore & LICENSE

* remove contribution section and add alternative choice
@LuckyPigeon
[docs] Remove docs $ prefix (rmax#229)
fe20458 
* remove docs $ prefix

* align code indent
@LuckyPigeon
Dev debug pytest (rmax#230)
b219e9f 
* add import hint for pytest

* update pytest usage

* update deprecated scrapy.utils.request usage

* Update .gitignore & LICENSE  (rmax#225)

* update .gitignore & LICENSE

* remove contribution section and add alternative choice

* [docs] Remove docs $ prefix (rmax#229)

* remove docs $ prefix

* align code indent

* add import hint for pytest

* add import hint for pytest

* add text color helper

* add json type check

add json formatted_data type check and warning message

* fix subset not equal assert

* update test & install guide
@songhao8080 @LuckyPigeon
fix push json (rmax#239)
ac8cc8a
@LuckyPigeon
Remove python 2.x support (rmax#231)
9b11ac5 
* remove python 2.x support

* python3.6 has already deprecated
@LuckyPigeon
update import scrapy_redis.utils (rmax#232)
a318c53
@LuckyPigeon
[test] Dev flake8 style (rmax#233)
f7b0073 
* add flake8 rules

* add flake8 guide

* fix flake8 style suggestion
@LuckyPigeon
[test] Dev bandit (rmax#234)
dd090c7 
* add bandit rules

* add bandit badge

* fix CWE-703
@LuckyPigeon @songhao8080
[test] Dev tox (rmax#237)
357f704 
* update tox.ini

* fix push json (rmax#239)

* Remove python 2.x support (rmax#231)

* remove python 2.x support

* python3.6 has already deprecated

* update import scrapy_redis.utils (rmax#232)

* [test] Dev flake8 style (rmax#233)

* add flake8 rules

* add flake8 guide

* fix flake8 style suggestion

* [test] Dev bandit (rmax#234)

* add bandit rules

* add bandit badge

* fix CWE-703

* replace pkg coverage with pytest-cov

* update CONTRIBUTING.rst to meet tox requirements

* update list indexes

Co-authored-by: songhao <[email protected]>
@LuckyPigeon
[docs] Update README.md (rmax#236)
95fcfe3 
* landscape.io is already down

* update requires.io badge

update requires.io badge, local temporarily

* update badge source

* update requirements version

* fix gh copy function

* fix gh copy function

* fix gh copy function

* fix gh copy function

* move running example section to example/

* update links

* update indent

* Update contribution link
@songhao8080 @LuckyPigeon
[dev] Default value for json support data (rmax#240)
768ab43 
* give default value to variable for push json

* add make_request_from_data comment

* update json supported data guide

* update json supported data guide

Co-authored-by: LuckyPigeon <[email protected]>
@LuckyPigeon
Merge branch 'master' into update_setup
5b3871b
rmax
rmax approved these changes May 13, 2022
View reviewed changes
Copy link
Owner

@rmax rmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!!

@LuckyPigeon LuckyPigeon merged commit a0342cc into rmax:master May 16, 2022
LuckyPigeon added a commit to LuckyPigeon/scrapy-redis that referenced this pull request Jul 16, 2022
@LuckyPigeon @songhao8080
Update setup (rmax#227)
b4dbe6b 
* remove redundant requirements files

* update setup.py and remove redundant functions

* update setup.py classifiers

* add requirements.txt for tox.ini to use

* update requirements.txt related settings

* update dependencies version

* update pkg version & introduce pytest-cov

* update python version

* Update .gitignore & LICENSE  (rmax#225)

* update .gitignore & LICENSE

* remove contribution section and add alternative choice

* [docs] Remove docs $ prefix (rmax#229)

* remove docs $ prefix

* align code indent

* Dev debug pytest (rmax#230)

* add import hint for pytest

* update pytest usage

* update deprecated scrapy.utils.request usage

* Update .gitignore & LICENSE  (rmax#225)

* update .gitignore & LICENSE

* remove contribution section and add alternative choice

* [docs] Remove docs $ prefix (rmax#229)

* remove docs $ prefix

* align code indent

* add import hint for pytest

* add import hint for pytest

* add text color helper

* add json type check

add json formatted_data type check and warning message

* fix subset not equal assert

* update test & install guide

* fix push json (rmax#239)

* Remove python 2.x support (rmax#231)

* remove python 2.x support

* python3.6 has already deprecated

* update import scrapy_redis.utils (rmax#232)

* [test] Dev flake8 style (rmax#233)

* add flake8 rules

* add flake8 guide

* fix flake8 style suggestion

* [test] Dev bandit (rmax#234)

* add bandit rules

* add bandit badge

* fix CWE-703

* [test] Dev tox (rmax#237)

* update tox.ini

* fix push json (rmax#239)

* Remove python 2.x support (rmax#231)

* remove python 2.x support

* python3.6 has already deprecated

* update import scrapy_redis.utils (rmax#232)

* [test] Dev flake8 style (rmax#233)

* add flake8 rules

* add flake8 guide

* fix flake8 style suggestion

* [test] Dev bandit (rmax#234)

* add bandit rules

* add bandit badge

* fix CWE-703

* replace pkg coverage with pytest-cov

* update CONTRIBUTING.rst to meet tox requirements

* update list indexes

Co-authored-by: songhao <[email protected]>

* [docs] Update README.md (rmax#236)

* landscape.io is already down

* update requires.io badge

update requires.io badge, local temporarily

* update badge source

* update requirements version

* fix gh copy function

* fix gh copy function

* fix gh copy function

* fix gh copy function

* move running example section to example/

* update links

* update indent

* Update contribution link

* [dev] Default value for json support data (rmax#240)

* give default value to variable for push json

* add make_request_from_data comment

* update json supported data guide

* update json supported data guide

Co-authored-by: LuckyPigeon <[email protected]>

* update flake8

Co-authored-by: songhao <[email protected]>
LuckyPigeon added a commit that referenced this pull request Jul 16, 2022
@LuckyPigeon @songhao8080
[test] Dev coverage (#235)
25f1c20 
* add coverage report

* fix push json (#239)

* Remove python 2.x support (#231)

* remove python 2.x support

* python3.6 has already deprecated

* update import scrapy_redis.utils (#232)

* [test] Dev flake8 style (#233)

* add flake8 rules

* add flake8 guide

* fix flake8 style suggestion

* [test] Dev bandit (#234)

* add bandit rules

* add bandit badge

* fix CWE-703

* [test] Dev tox (#237)

* update tox.ini

* fix push json (#239)

* Remove python 2.x support (#231)

* remove python 2.x support

* python3.6 has already deprecated

* update import scrapy_redis.utils (#232)

* [test] Dev flake8 style (#233)

* add flake8 rules

* add flake8 guide

* fix flake8 style suggestion

* [test] Dev bandit (#234)

* add bandit rules

* add bandit badge

* fix CWE-703

* replace pkg coverage with pytest-cov

* update CONTRIBUTING.rst to meet tox requirements

* update list indexes

Co-authored-by: songhao <[email protected]>

* [docs] Update README.md (#236)

* landscape.io is already down

* update requires.io badge

update requires.io badge, local temporarily

* update badge source

* update requirements version

* fix gh copy function

* fix gh copy function

* fix gh copy function

* fix gh copy function

* move running example section to example/

* update links

* update indent

* Update contribution link

* [dev] Default value for json support data (#240)

* give default value to variable for push json

* add make_request_from_data comment

* update json supported data guide

* update json supported data guide

Co-authored-by: LuckyPigeon <[email protected]>

* Dev tox matrix (#244)

* support scarpy 1.x

* add python-scrapy tox matrix

* fix flake8 style

* add python-scrapy-redis matrix

* [test] Dev tox pylint (#247)

* add pylintrc

* add pylint for tox

* update pylint rules

* [style] Fix pylint style (#246)

* convert string to fstring for src/

* convert string to fstring for tests/

* remove u-string prefix

* Update setup (#227)

* remove redundant requirements files

* update setup.py and remove redundant functions

* update setup.py classifiers

* add requirements.txt for tox.ini to use

* update requirements.txt related settings

* update dependencies version

* update pkg version & introduce pytest-cov

* update python version

* Update .gitignore & LICENSE  (#225)

* update .gitignore & LICENSE

* remove contribution section and add alternative choice

* [docs] Remove docs $ prefix (#229)

* remove docs $ prefix

* align code indent

* Dev debug pytest (#230)

* add import hint for pytest

* update pytest usage

* update deprecated scrapy.utils.request usage

* Update .gitignore & LICENSE  (#225)

* update .gitignore & LICENSE

* remove contribution section and add alternative choice

* [docs] Remove docs $ prefix (#229)

* remove docs $ prefix

* align code indent

* add import hint for pytest

* add import hint for pytest

* add text color helper

* add json type check

add json formatted_data type check and warning message

* fix subset not equal assert

* update test & install guide

* fix push json (#239)

* Remove python 2.x support (#231)

* remove python 2.x support

* python3.6 has already deprecated

* update import scrapy_redis.utils (#232)

* [test] Dev flake8 style (#233)

* add flake8 rules

* add flake8 guide

* fix flake8 style suggestion

* [test] Dev bandit (#234)

* add bandit rules

* add bandit badge

* fix CWE-703

* [test] Dev tox (#237)

* update tox.ini

* fix push json (#239)

* Remove python 2.x support (#231)

* remove python 2.x support

* python3.6 has already deprecated

* update import scrapy_redis.utils (#232)

* [test] Dev flake8 style (#233)

* add flake8 rules

* add flake8 guide

* fix flake8 style suggestion

* [test] Dev bandit (#234)

* add bandit rules

* add bandit badge

* fix CWE-703

* replace pkg coverage with pytest-cov

* update CONTRIBUTING.rst to meet tox requirements

* update list indexes

Co-authored-by: songhao <[email protected]>

* [docs] Update README.md (#236)

* landscape.io is already down

* update requires.io badge

update requires.io badge, local temporarily

* update badge source

* update requirements version

* fix gh copy function

* fix gh copy function

* fix gh copy function

* fix gh copy function

* move running example section to example/

* update links

* update indent

* Update contribution link

* [dev] Default value for json support data (#240)

* give default value to variable for push json

* add make_request_from_data comment

* update json supported data guide

* update json supported data guide

Co-authored-by: LuckyPigeon <[email protected]>

* update flake8

Co-authored-by: songhao <[email protected]>

* convert the data from redis from bytes to str (#249)

* ignore setup.py coverage

Co-authored-by: songhao <[email protected]>
@LuckyPigeon LuckyPigeon mentioned this pull request Jul 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmax rmax rmax approved these changes

@Germey Germey Awaiting requested review from Germey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update basic settings
3 participants
@LuckyPigeon @rmax @songhao8080