Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wind Pronunciation and Game Time #80

Closed
dbnewell opened this issue Jan 15, 2021 · 7 comments
Closed

Wind Pronunciation and Game Time #80

dbnewell opened this issue Jan 15, 2021 · 7 comments

Comments

@dbnewell
Copy link

Is it possible to change the spelling of "wind" in the code so when it is sent to the tts is is pronounced correctly? possibly change it to "wend" or "whend"? Could the in game time in zulu time be added to the automated ATIS broadcast? Thanks

@rkusa
Copy link
Owner

rkusa commented Jan 16, 2021

possibly change it to "wend" or "whend"?

As a non native English speaking person, I didn't notice that the pronunciation is off, but I'll look into it, thanks for the feedback!

Could the in game time in zulu time be added to the automated ATIS broadcast?

I'd probably tend to avoid that to reduce the amount of TTS that is necessary, because right now, the result of TTS is cached and reused until the report changes. This reduces the costs for AWS/GCloud based TTS significantly (see also #77). What would be your use-case for this?

@dbnewell
Copy link
Author

dbnewell commented Jan 16, 2021 via email

@rkusa
Copy link
Owner

rkusa commented Jan 16, 2021

Would it be a possibility to add it as an optional function to enable or disable in the ATIS reports as we are using the windows tts implementation for the ATIS reports on our servers? I understand the need to cache the report and limit the report changes for using external tts services.

Since it doesn't really matter for WIN TTS, having it as an optional feature would be a valid approach. I just remembered that I often see mission time differences between different pilots in MP. So having it in the ATIS report might even be an easy way of having a somewhat accurate time sync 🤔

@rkusa
Copy link
Owner

rkusa commented Jan 19, 2021

@dbnewell I've looked into the wind pronunciation and it sounds correct to me (though I am not a native English speaker). Still, which TTS voice are you using where you'd say that the pronunciation could be improved?

@dbnewell
Copy link
Author

dbnewell commented Jan 19, 2021 via email

rkusa added a commit that referenced this issue Jan 22, 2021
@rkusa
Copy link
Owner

rkusa commented Jan 22, 2021

I must have tested GCloud or AWS instead of WIN TTS, since it is indeed quite obvious wrong with WIN TTS. It is fixed now, and will be released in the next couple of days as part of 2.2.1. Thanks again for the report. While a small change, I think it is has quite a big impact on immersion! If you hear anything else where the pronunciation is off, please let me know.

@rkusa rkusa closed this as completed Jan 22, 2021
@dbnewell
Copy link
Author

dbnewell commented Jan 22, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants