LibCore: Add a way to set an individual Core::Object property remotely

rkm · Mar 5, 2020 · 42f2696 · 42f2696
1 parent ca110a6
commit 42f2696
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 0 deletions.
diff --git a/Libraries/LibCore/EventLoop.cpp b/Libraries/LibCore/EventLoop.cpp
@@ -171,8 +171,25 @@ class RPCClient : public Object {
  m_inspected_object->decrement_inspector_count({});
  m_inspected_object = object.make_weak_ptr();
  m_inspected_object->increment_inspector_count({});
+ break;
  }
  }
+ return;
+ }
+
+ if (type == "SetProperty") {
+ auto address = request.get("address").to_number<uintptr_t>();
+ for (auto& object : Object::all_objects()) {
+ if ((uintptr_t)&object == address) {
+ bool success = object.set_property(request.get("name").to_string(), request.get("value"));
+ JsonObject response;
+ response.set("type", "SetProperty");
+ response.set("success", success);
+ send_response(response);
+ break;
+ }
+ }
+ return;
  }
 
  if (type == "Disconnect") {

diff --git a/Libraries/LibCore/Object.cpp b/Libraries/LibCore/Object.cpp
@@ -173,6 +173,15 @@ void Object::save_to(JsonObject& json)
  json.set("parent", (uintptr_t)parent());
 }
 
+bool Object::set_property(const StringView& name, const JsonValue& value)
+{
+ if (name == "name") {
+ set_name(value.to_string());
+ return true;
+ }
+ return false;
+}
+
 bool Object::is_ancestor_of(const Object& other) const
 {
  if (&other == this)

diff --git a/Libraries/LibCore/Object.h b/Libraries/LibCore/Object.h
@@ -111,6 +111,7 @@ class Object
  virtual bool is_window() const { return false; }
 
  virtual void save_to(AK::JsonObject&);
+ virtual bool set_property(const StringView& name, const JsonValue& value);
 
  static IntrusiveList<Object, &Object::m_all_objects_list_node>& all_objects();