Fix/link ospids to wrek vert #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkallos
force-pushed
the
fix/link-ospid-to-wrek-vert
branch
from
2ae02e2
to
49a39fe
Compare
This commit makes wrek_vert call exec:run_link instead of a callback process. Since wrek_vert traps exits, it can report the return codes of OS processes to interested Erlang processes using the fun returned through wrek_vert:exec. This fixes the nasty bug where a child process of the wrek_vert callback process spawned OS processes using exec:run_link without trapping exits, causing cascading process crashes when the OS process returned a non-zero exit code.
Note: Verts that call wrek_vert:exec should change their match patterns to
account for the new {ok, _} | {error, _} return value.
rkallos
force-pushed
the
fix/link-ospid-to-wrek-vert
branch
from
1f2c69f
to
4f14c33
Compare
RAttab
reviewed
Jan 17, 2019
| lists:foreach(fun(From) -> | ||
| gen_server:reply(From, Result) | ||
| end, Waits), | ||
| Pids2 = Pids#{Pid => {result, Result}}, |
There was a problem hiding this comment.
Just to confirm, this map will not grow infinitely because it'll get wiped once the vert is done executing. Meaning that we don't reuse a vert process to run multiple instances of a vert.
|
Confirmed! The number of entries in the map corresponds to the number of OS
processes spawned by the callback process. Once the callback process shuts
down, normally or otherwise, the wrek_vert gen_server (and the map) will be
reaped.
…On Thu, Jan 17, 2019, 11:26 AM Rémi Attab ***@***.*** wrote:
***@***.**** commented on this pull request.
------------------------------
In src/wrek_vert.erl
<#21 (comment)>:
> + Child ->
+ wrek_event:vert_done(EvMgr, id(State), Term),
+ {stop, {shutdown, Term}, State};
+ _ ->
+ case Pids of
+ #{Pid := Waits} ->
+ Result = case Term of
+ normal -> ok;
+ {exit_status, _Status} = Exit ->
+ {error, Exit};
+ _ -> Term
+ end,
+ lists:foreach(fun(From) ->
+ gen_server:reply(From, Result)
+ end, Waits),
+ Pids2 = Pids#{Pid => {result, Result}},
Just to confirm, this map will not grow infinitely because it'll get wiped
once the vert is done executing. Meaning that we don't reuse a vert process
to run multiple instances of a vert.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#21 (review)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAikoai0EXtoWEB2qpOSW1MSkPItNIKEks5vEKROgaJpZM4aEAvl>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.