Fix/get from kv #17
Merged
Fix/get from kv #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkallos
force-pushed
the
fix/get-from-kv
branch
from
aaa9f9b
to
dd4874b
Compare
fbernier
approved these changes
Jan 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrek_vert_t:succeed/2would overwrite any KV pairs passed in through the definition of a vert. As a result, callingwrek_vert:get/3on one of these keys would fail.I also renamed the records defined in
wrek_tandwrek_vert_tto be?MODULEinstead oft, making debugging much less confusing.Thanks @fbernier for bringing this to my attention.