Skip to content

Tags: rinkydevi/terminal

Tags

Verified

This tag was signed with the committer’s verified signature.
DHowett Dustin L. Howett

Verified

This tag was signed with the committer’s verified signature.
DHowett Dustin L. Howett

v1.11.2731.0

Toggle v1.11.2731.0's commit message
[deadlock fix] Remove lock for SIUP::GetSelectionRange() (microsoft#1…

…1386)

## Summary of the Pull Request
The deadlock was caused by `ScreenInfoUiaProviderBase::GetSelection()` calling `TermControlUiaProvider::GetSelectionRange` (both of which attempted to lock the console). This PR removes the lock and initialization check from `TermControlUiaProvider`. It is no longer necessary because the only one that calls it is `SIUPB::GetSelection()`.

Additionally, this adds some code that was useful in debugging this race condition. That should help us figure out any locking issues that may come up in the future.

## References
microsoft#11312
Closes microsoft#11385 

## Validation Steps Performed
✅ Repro steps don't cause hang

v1.10.2714.0

Toggle v1.10.2714.0's commit message
fix namespace thing

Verified

This tag was signed with the committer’s verified signature.
DHowett Dustin L. Howett