Restored test for port 0.

rigzba21 · Jun 27, 2022 · 9aa45aa · 9aa45aa
1 parent f52f641
commit 9aa45aa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/oauthlib/oauth1/rfc5849/signature.py b/oauthlib/oauth1/rfc5849/signature.py
@@ -198,7 +198,7 @@ def base_string_uri(uri: str, host: str = None) -> str:
  elif isinstance(hostname, ipaddress.IPv4Address):
  hostname = f"{hostname}"
 
- if port is not None and not (0 <= port <= 65535):
+ if port is not None and not (0 < port <= 65535):
  raise ValueError('port out of range') # 16-bit unsigned ints
  if (scheme, port) in (('http', 80), ('https', 443)):
  netloc = hostname # default port for scheme: exclude port num

diff --git a/tests/oauth1/rfc5849/test_signatures.py b/tests/oauth1/rfc5849/test_signatures.py
@@ -348,6 +348,7 @@ def test_base_string_uri(self):
  self.assertRaises(ValueError, base_string_uri, 'http:https://:8080')
 
  # Port is not a valid TCP/IP port number
+ self.assertRaises(ValueError, base_string_uri, 'http:https://eg.com:0')
  self.assertRaises(ValueError, base_string_uri, 'http:https://eg.com:-1')
  self.assertRaises(ValueError, base_string_uri, 'http:https://eg.com:65536')
  self.assertRaises(ValueError, base_string_uri, 'http:https://eg.com:3.14')