-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise serde mapping of ruststep::ast #222
Closed
Closed
+189
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
termoshtt
changed the title
Revise serde mapping of
Revise serde mapping of ruststep::ast
May 16, 2022
ruststep::ast::{Parameter, Record}
termoshtt
commented
May 16, 2022
@@ -86,7 +86,7 @@ | |||
//! - `HEADER` section has three components `FILE_DESCRIPTION`, `FILE_NAME`, and `FILE_SCHEMA`. | |||
//! - See [header] module document for detail. | |||
//! - Each data is in form `TYPE_NAME(parameter1, ...)`. | |||
//! - This is called "Record". | |||
//! - This is called "SimpleEntityInstance". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be remained as "Record"
termoshtt
force-pushed
the
revise-serde-mapping
branch
from
May 16, 2022 03:42
44821fa
to
adb4b57
Compare
In this case following all instances are complex entity instance
Thus, we should not use the naming "simple entity instance" for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #220
RecordDeserializer
forParameter::Ref
→ Do not useRecordDeserializer
forName
#224ast::Name
→ Do not useRecordDeserializer
forName
#224Record
intoSimpleEntityInstance
ComplexEntityInstance
struct and implementDeserializer
Parameter::Typed
andRecord
into "struct" in serde model