forked from ray-project/ray
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add a basic rule to contributors / PR template. (ray-project#10277)
* Add a basic rule to contributors / PR template. * Fix. * Addressed code reivew.
- Loading branch information
Showing
2 changed files
with
21 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,3 +25,22 @@ To contribute a patch: | |
.. _`[email protected]`: https://groups.google.com/forum/#!forum/ray-dev | ||
.. _`GitHub Issues`: https://github.com/ray-project/ray/issues | ||
.. _`StackOverflow`: https://stackoverflow.com/questions/tagged/ray | ||
|
||
PR Review Process | ||
----------------- | ||
|
||
For contributors who are in the ray-project organization: | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
- When you first create a PR, add an reviewer to the `assignee` section. | ||
- Assignees will review your PR and add `@author-action-required` label if further actions are required. | ||
- Address their comments and remove `@author-action-required` label from the PR. | ||
- Repeat this process until assignees approve your PR. | ||
- Once the PR is approved, the author is in charge of ensuring the PR passes the build. Add `test-ok` label if the build succeeds. | ||
- Committers will merge the PR once the build is passing. | ||
|
||
For contributors who are not in the ray-project organization: | ||
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
||
- Your PRs will have assignees shortly. Assignees or PRs will be actively engaging with contributors to merge the PR. | ||
- Please actively ping assignees after you address your comments! |