Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FieldSelector to select only tls secrets #82

Merged
merged 1 commit into from
Dec 23, 2021
Merged

Use FieldSelector to select only tls secrets #82

merged 1 commit into from
Dec 23, 2021

Conversation

sechmann
Copy link
Contributor

This speeds up the listing of certs significatnyly in clusters with many secrets.

This fixed a timeout issue for us.

ribbybibby
ribbybibby requested changes Nov 12, 2021
View reviewed changes
Copy link
Owner

@ribbybibby ribbybibby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I'll make some time to test it out this weekend.

In the meantime, could you remove the change to the VERSION file? I'll bump that myself when I cut a release.

@sechmann
Use FieldSelector to select only tls secrets
0525d48 
This speeds up the listing of certs significatnyly in clusters with many secrets.
ribbybibby
ribbybibby approved these changes Dec 23, 2021
View reviewed changes
Copy link
Owner

@ribbybibby ribbybibby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ribbybibby ribbybibby merged commit a8dcb43 into ribbybibby:master Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ribbybibby ribbybibby ribbybibby approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sechmann @ribbybibby