Add support for postgresql protocol #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarvip
force-pushed
the
postgres-support
branch
3 times, most recently
from
2a18b2d
to
6efd4b2
Compare
ribbybibby
reviewed
Aug 20, 2021
ribbybibby
reviewed
Aug 20, 2021
There was a problem hiding this comment.
This looks great, thank you so much for the contribution! I kept meaning to get around to adding this feature but never found the time.
I've left one small comment about the name of the option, other than that it looks good to me.
I'm going to spin up a postgres to check it out as soon as I can.
With postgresql to initiate SSL-encrypted connection specific combination of bytes must be sent to the server. Message flow is described on following page https://www.postgresql.org/docs/13/protocol-flow.html#id-1.10.5.7.11 And SSLRequest message format is described on https://www.postgresql.org/docs/13/protocol-message-formats.html The value of SSLRequest message becomes to bytes that is used in the code
tarvip
force-pushed
the
postgres-support
branch
from
6efd4b2
to
abe8ed1
Compare
ribbybibby
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With postgresql to initiate SSL-encrypted connection specific combination
of bytes must be sent to the server.
Message flow is described on following page
https://www.postgresql.org/docs/13/protocol-flow.html#id-1.10.5.7.11
And SSLRequest message format is described on
https://www.postgresql.org/docs/13/protocol-message-formats.html
The value of SSLRequest message becomes to bytes that is used in the code