Export OCSP stapling metrics #54
Conversation
|
This looks great! One question, how would the values look if the certificate had no OCSP response stapled to it? Would it make sense to add a 0/1 metric specifically for determining this? |
|
@tykling Yep, that makes sense to me. I've added that. |
|
hello, is there anything I can do to expedite getting this merged? |
|
Hi @tykling. I need to rebase on top of some other changes that have been merged to master, I'll try to get to that today. I would appreciate any further comments you have on the changes, or a thumbs up if it looks okay. After that I'm happy to merge. |
| | ----------------------------- | ------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------- | | ||
| | ssl_cert_not_after | The date after which a peer certificate expires. Expressed as a Unix Epoch Time. | serial_no, issuer_cn, cn, dnsnames, ips, emails, ou | | ||
| | ssl_cert_not_before | The date before which a peer certificate is not valid. Expressed as a Unix Epoch Time. | serial_no, issuer_cn, cn, dnsnames, ips, emails, ou | | ||
| | ssl_ocsp_response_next_update | The nextUpdate value in the OCSP response. Expressed as a Unix Epoch Time | | |
There was a problem hiding this comment.
ssl_ocsp_response_this_update is missing here I think?
|
Looks good apart from the small docs thing 👍 |
ribbybibby
force-pushed
the
ocsp-stapling
branch
from
52a0cae
to
13e30e3
Compare
|
Great, thanks for the review! I've amended the README and rebased, so I'm going to merge now. I'll look at cutting a release soon, I just need to check if there are any other changes pending implementation that I'd like to sneak in first. |
No description provided.