Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to netstandard 2.0 and nodatime 3 + cleanup #499

Merged
merged 4 commits into from
Apr 10, 2021
Merged

Migrate to netstandard 2.0 and nodatime 3 + cleanup #499

merged 4 commits into from
Apr 10, 2021

Conversation

davidroth
Copy link
Contributor

@davidroth davidroth commented Aug 18, 2020 •
edited
Loading

This version has been cleaned and upgraded to netstandard 2.0
Changes compared to official package:

  • Target netstandard 2.0 / netfx472
  • Use netcoreapp 3.1 for tests
  • Upgrade noda time package to latest version (3.0)
  • Removed unusued references
  • Removed duplicate FrameworkUnitTests

If anyone needs this package now, please use my forked nuget: https://www.nuget.org/packages/Fusonic.Ical.Net/5.0.3

@davidroth davidroth mentioned this pull request Aug 18, 2020
Open
@davidroth davidroth changed the title Migrate to netstandard 2.0 and nodatime 3 Migrate to netstandard 2.0 and nodatime 3 + cleanup Aug 18, 2020
@davidroth davidroth mentioned this pull request Oct 1, 2020
Open
@rianjs
Copy link
Owner

rianjs commented Apr 10, 2021

Just making notes to myself:

  • Figure out what the new ical version number should be, and change it
  • Fix PackageId in the csproj
  • Figure out why I had Framework-specific unit tests -- there was a reason

@rianjs rianjs merged commit 62ea8a3 into rianjs:master Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rianjs rianjs rianjs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidroth @rianjs