Fixed potential stack overflow when calculating changes to DtStart, DtEnd, etc. #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes here came from our copy of ical.net. Figured it would be good to push these potentially back. We were seeing some production systems getting stack overflows caused by some fields not being provided when creating a calendar event then setting a value. After setting this value ExtrapolateTimes would then start looping when attempting to set other DtStart, Duration, DtEnd values.
p.s This is my first pull request, familiar with using open source projects but this is my first time going upstream. If there are any changes or suggestions let me know.