Infiinte Loop with MaxDate for GetOccurrences #364
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug when GetOccurrences ends on MaxDate and only Count is set, an error is thrown inside an infinite loop
pomoika
reviewed
Mar 7, 2018
| @@ -259,11 +259,21 @@ private void EnforceEvaluationRestrictions(RecurrencePattern pattern) | |||
| break; | |||
| } | |||
|
|
|||
| if (pattern.Until != DateTime.MinValue && candidate != DateTime.MinValue && candidate > pattern.Until) | |||
There was a problem hiding this comment.
This condition is exact duplicate of the above statement, therefore it should be removed.
There was a problem hiding this comment.
Good catch. This was an accident. Removed the duplication. @pomoika
|
Running into this as well after upgrading from 3.0.6 to 4.1.2 .. any reason this hasn't been merged in yet? |
|
@rianjs Any chance we can get this reviewed and merged? This bug is preventing us from upgrading to latest version. |
rianjs
added a commit
that referenced
this pull request
Apr 10, 2021
Fix Infinite Loop with MaxDate for GetOccurrences - closes #364
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug when GetOccurrences ends on MaxDate and only Count is set, an
error is thrown inside an infinite loop