Minor performance improvements #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The text was already normalized by the SerializerBase.
Many of these lists will only ever have a single entry.
rianjs
reviewed
Mar 20, 2017
| @@ -102,7 +102,7 @@ public override string SerializeToString(object obj) | |||
| return string.Join(",", values); | |||
| } | |||
|
|
|||
| internal static readonly Regex UnescapedCommas = new Regex(@"[^\\](,)", RegexOptions.Compiled); | |||
| internal static readonly Regex UnescapedCommas = new Regex(@"(?<!\\),", RegexOptions.Compiled); | |||
There was a problem hiding this comment.
It matches commas that are not preceded by backslashes. The (?<foo) construct is a zero-width negative lookbehind assertion, which means it ensures the characters before that point don't match the given regex.
rianjs
reviewed
Mar 20, 2017
There was a problem hiding this comment.
Oh, I specified collection sizes a while ago. 128 is probably unnecessarily large. 4 would probably suffice in 80%+ of cases, and since 4 is effectively "free", I'm OK with the change.
This was my thinking when I specified initial sizes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are a few other potential performance improvements I noticed while profiling deserialization.