Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release note for network port devices' default configuration profiles #5728

Conversation

rvykydal
Copy link
Contributor

Relase note for #5703

Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The note is perfect, only tiny typo in the commit message.

s/confiuration/configuration

:Summmary: Do not create default network profiles for network port devices

:Description:
Traditionally Anaconda creates default persistent network profiles (ifcfg files or keyfiles) for every supported wired network device. We would like to move towards creating profiles only for devices explicitly configured by installer. As a step in this direction do not create such files for devices used as ports of a virtual device (eg bond device) configured by installer, unless they were explicitly configured separately (for example in early stage from boot options).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/eg bond device/e.g., bond device

Copy link
Contributor Author

@rvykydal rvykydal Jul 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KKoukiou Updated.

@rvykydal rvykydal force-pushed the add-release-note-for-network-virtual-port-devices branch from 59d2f0c to ee33ff8 Compare July 15, 2024 08:51
@KKoukiou
Copy link
Contributor

The note is perfect, only tiny typo in the commit message.

s/confiuration/configuration

@rvykydal I think you missed this one :) Will update it quickly for you and merge.

@KKoukiou KKoukiou force-pushed the add-release-note-for-network-virtual-port-devices branch from ee33ff8 to d39881c Compare July 19, 2024 11:41
@KKoukiou KKoukiou changed the title Add release note for network port devices' default confiuration profiles Add release note for network port devices' default configuration profiles Jul 19, 2024
@KKoukiou
Copy link
Contributor

/kickstart-tests --waive docs

@rvykydal
Copy link
Contributor Author

The note is perfect, only tiny typo in the commit message.
s/confiuration/configuration

@rvykydal I think you missed this one :) Will update it quickly for you and merge.

Thank you :)

@KKoukiou KKoukiou merged commit 480135b into rhinstaller:master Aug 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants