Remove deprecated warnings for inst prefix #5723
Open
+41
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build-image |
|
/kickstart-tests --testtype dracut |
|
Images built based on commit 367ac1a:
Download the images from the bottom of the job status page. |
KKoukiou
requested changes
Jun 27, 2024
r0x0d
force-pushed
the
remove-deprecated-warnings-for-inst
branch
from
367ac1a
to
5db8a1e
Compare
r0x0d
force-pushed
the
remove-deprecated-warnings-for-inst
branch
from
5db8a1e
to
ca0a458
Compare
There were a couple of places were warnings were left behind to warn the users that using `inst.` was now required for some boot options. This patch removes the warnings as it is mandatory to have the prefix for those options.
r0x0d
force-pushed
the
remove-deprecated-warnings-for-inst
branch
from
ca0a458
to
0a3fcab
Compare
|
/kickstart-tests --testtype smoke |
|
/kickstart-tests --testtype dracut |
KKoukiou
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
We need to adjust 'dracut-visible-warnings.sh' test in https://github.com/rhinstaller/kickstart-tests/ repository and merge in one go.
|
/kickstart-tests --testtype dracut |
r0x0d
force-pushed
the
remove-deprecated-warnings-for-inst
branch
from
bcb7741
to
0a3fcab
Compare
r0x0d
added a commit
to r0x0d/kickstart-tests
that referenced
this pull request
Jul 8, 2024
We removed the deprecated warnings for inst.* in anaconda, thus, this test will always assert for something that will not appear anymore Anaconda PR: rhinstaller/anaconda#5723
|
Kickstart PR: rhinstaller/kickstart-tests#1239 |
|
@jstodola are you fine with doing this now? I guess it's fine for RHEL-11 to do this? |
|
Yes, I'm fine with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a couple of places were warnings were left behind to warn the users that using
inst.was now required for some boot options. This patch removes the warnings as it is mandatory to have the prefix for those options.