webui: Dont run browser as root #5689
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
The titlebar with "Mozilla Firefox" has been fixed but there are some more bits that can be cleaned up. This commit achieves that by: 1. Make sure more of the environment is bubbled through anaconda to the webui launcher. In particular, we need XDG_CURRENT_DESKTOP, but this commit brings it all through, so firefox runs in an environment as close to getting run directly by the live user as possible. 2. Two exceptions are XAUTHORITY and XDG_RUNTIME_DIR which need to remain unset until we can run firefox as a normal user instead of root.
adamkankovsky
force-pushed
the
dont-run-browser-as-root-alias
branch
from
5b7b862
to
c628fca
Compare
|
/build-image --live |
|
Images built based on commit c628fca:
Download the images from the bottom of the job status page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspirated by: #5058
This changes for liveOS was tested and works