Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kickstart --dhcpclass option application #5682

Merged

Conversation

rvykydal
Copy link
Contributor

Port of upstream fix #5563 which didn't make it into rhel10.

The option stopped working with
commit 0da378c

Kickstart test network-options-pre should be updated to check this
functionality.

Resolves: RHEL-38998
@pep8speaks
Copy link

Hello @rvykydal! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 692:100: E501 line too long (104 > 99 characters)
Line 713:100: E501 line too long (102 > 99 characters)
Line 737:100: E501 line too long (102 > 99 characters)
Line 758:100: E501 line too long (102 > 99 characters)
Line 782:100: E501 line too long (102 > 99 characters)
Line 804:100: E501 line too long (102 > 99 characters)
Line 825:100: E501 line too long (102 > 99 characters)
Line 848:100: E501 line too long (102 > 99 characters)
Line 872:100: E501 line too long (102 > 99 characters)
Line 896:100: E501 line too long (102 > 99 characters)
Line 933:100: E501 line too long (102 > 99 characters)

@rvykydal
Copy link
Contributor Author

We need also to update related kickstart test in a way similar to rhinstaller/kickstart-tests#1206

@rvykydal
Copy link
Contributor Author

/kickstar-test --testtype smoke

@rvykydal
Copy link
Contributor Author

/kickstart-test --testtype smoke

Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. :)

Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rvykydal rvykydal merged commit cdf225a into rhinstaller:rhel-10 Jun 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants