Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change location of rescue mode flag file #5680

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

jstodola
Copy link
Contributor

The file indicating that the installer is running is rescue mode needs to be accessible for %post scripts running in nochroot as well as in chroot. Create the file in /run/install/, so that both 80-setfilecons.ks and 99-copy-logs.ks work correctly.

Resolves: RHEL-4794

This is a correction of #5640

The file indicating that the installer is running is rescue mode needs
to be accessible for %post scripts running in nochroot as well as in
chroot. Create the file in /run/install/, so that both 80-setfilecons.ks
and 99-copy-logs.ks work correctly.

Resolves: RHEL-4794
@jstodola
Copy link
Contributor Author

/kickstart-test --testtype smoke

Copy link
Member

@jkonecny12 jkonecny12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, the chroot / non-chroot issue. Looks good to me.

@jkonecny12
Copy link
Member

@jstodola I guess we want to backport this to Fedora and RHEL-10?

@jstodola
Copy link
Contributor Author

It is not necessary to backport it, I was not able to reproduce this problem on RHEL-10/Rawhide (#5640 (comment)). This part of code is completely different there.

Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well, thanks! :)

@jstodola jstodola added the ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). label Jul 1, 2024
@KKoukiou KKoukiou merged commit db30e52 into rhinstaller:rhel-9 Jul 1, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR can be merged. It should have all BZ flags required for releasing set (usually release+). rhel-9
4 participants