Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new generate_changelog script #5642

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add new generate_changelog script #5642

wants to merge 2 commits into from

Conversation

jkonecny12
Copy link
Member

@jkonecny12 jkonecny12 commented May 9, 2024 •
edited
Loading

Add script to generate changelog based on the git history. You can specify tags/commit/HEAD range or without arguments this script will just take last two tags.

Next steps would be:

  • Remove this logic from makebumpver
  • Use this script during the Release creation
  • Remove changelog from the anaconda.spec.in and leave this on Packit to handle based on the Release description

@jkonecny12
infra: Add generate_changelog script
bff1682 
This script will generate changelog from git versions. Main purpose of
this script is to split this logic from the makebumpver and get rid of
changelog in the upstream repository spec file.

This script will be used to generate GitHub versions.
@jkonecny12
infra: Implement log generator
454e885 
Generate log from commits between specified versions.
@github-actions github-actions bot added the f41 label May 9, 2024
@jkonecny12
Copy link
Member Author

/kickstart-test --waive infra only

@jkonecny12 jkonecny12 changed the title Add new changelog script Add new generate_changelog script May 10, 2024
M4rtinK
M4rtinK approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

KKoukiou
KKoukiou reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@KKoukiou KKoukiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioed in slack, I would advice that we introduce this script only when we start using it. Otherwise we dont have a way to verify that it's actual, and also it does not provide any help if not integrated.

@jkonecny12
Copy link
Member Author

I already used this script when I was fixing issues with the last two versions. So I don't think it's not useful, however if you really want a bigger PR instead of smaller ones, I don't have a problem with that.

@KKoukiou
Copy link
Contributor

I already used this script when I was fixing issues with the last two versions. So I don't think it's not useful, however if you really want a bigger PR instead of smaller ones, I don't have a problem with that.

Yes I prefer to do that in one go, because if the second part of the task will not get implemented this is all with no purpose.

@jkonecny12
Copy link
Member Author

We had a discussion with @KKoukiou that this script could be extended to work to cover also the recommended format of changelog in spec files where spec file should contain only information about fixed bugs and "Update to version..." instead of detailed change list.

This script could be easily extended to give list of these bugs which could be then used by:
https://packit.dev/docs/configuration/actions#syncing-the-release or maybe even env part in the packit configuration file.

@KKoukiou KKoukiou marked this pull request as draft June 24, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KKoukiou KKoukiou KKoukiou left review comments

@M4rtinK M4rtinK M4rtinK approved these changes

Assignees
No one assigned
Labels
f41
Milestone
No milestone
3 participants
@jkonecny12 @KKoukiou @M4rtinK