-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove threading compatibility layer #5570
Conversation
Hello @KKoukiou! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
/kickstart-test --testtype smoke |
If we want to do this, I would rather like to see something like |
Also I see only removal of file in this PR, isn't there something missed here? |
Agreed that if this is about a naming collision, a replacement should have "anaconda" in its name to fix it for good. Provided we really need it. The suggestion from Miro on the bug to stop using this weird pycompile script also sounds interesting: https://bugzilla.redhat.com/show_bug.cgi?id=2275279#c15 But indeed, hard to tell how hard it it is to change it now & what other unexpected side effects it might have (maybe something depends on the pyc files in a weird way in our CI & might break if they are not there (in built but unpackaged code) ?). |
This PR is stale because it has been open 60 days with no activity. |
We cannot have a module called 'threading', otherwise the build will fail with the traceback below. Remove this file as it was anyhow meant to be an intermediate compatibility solution. The traceback from the build: Traceback (most recent call last): File "<string>", line 2, in <module> File "/usr/lib64/python3.12/py_compile.py", line 9, in <module> import importlib.util File "<frozen importlib.util>", line 16, in <module> File "/builddir/build/BUILD/anaconda-41.10/pyanaconda/threading.py", line 21, in <module> from pyanaconda.core.threads import thread_manager as threadMgr ModuleNotFoundError: No module named 'pyanaconda' Resolves: rhbz#2275279
@jkonecny12 I think we can merge this now that inital setup released. Checked kdump for possible breackable - seemed not affected. If some other plugin will be affected, it's fine - we will fix it. |
I think we should also propose fix for oscap addon before doing this: |
Did we check the Anaconda kdump addon is compatible with the new thing ? |
Looks kdump should be fine. For OSCAP @KKoukiou created an issue: OpenSCAP/oscap-anaconda-addon#253 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now.
/kickstart-tests --testtype smoke |
Thanks for pushing forward with this! It's one of those eternal todos... |
/kickstart-tests --testtype smoke |
We cannot have a module called 'threading', otherwise the build will fail with
the traceback below. Remove this file as it was anyhow meant to be an
intermediate compatibility solution.
The traceback from the build:
Traceback (most recent call last):
File "", line 2, in
File "/usr/lib64/python3.12/py_compile.py", line 9, in
import importlib.util
File "", line 16, in
File "/builddir/build/BUILD/anaconda-41.10/pyanaconda/threading.py", line 21, in
from pyanaconda.core.threads import thread_manager as threadMgr
ModuleNotFoundError: No module named 'pyanaconda'
Resolves: rhbz#2275279
Blocked by: