Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network: add inst.waitfornet.global boot option #5507

Closed
wants to merge 1 commit into from
Closed

network: add inst.waitfornet.global boot option #5507

wants to merge 1 commit into from

Conversation

rvykydal
Copy link
Contributor

@rvykydal rvykydal commented Mar 6, 2024 •
edited
Loading

@rvykydal
network: add inst.waitfornet.global boot option
b3e0d7d 
Behaves like inst.waitfornet but requires NetworkManger's
CONNECTED_GLOBAL connectivity.
@pep8speaks
Copy link

Hello @rvykydal! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 342:100: E501 line too long (111 > 99 characters)

@rvykydal rvykydal added the blocked Don't merge this pull request! label Mar 6, 2024
M4rtinK
M4rtinK approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - really like the . notation, looks nice & makes much sense now that every boot option we provide has the inst. prefix anyway. :)

@rvykydal
Copy link
Contributor Author

/kickstart-test lang

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024

This PR is stale because it has been open 60 days with no activity.
Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions bot added the stale label Jun 9, 2024
@github-actions GitHub Actions
Copy link

This PR was closed because it has been stalled for 30 days with no activity.

@github-actions github-actions bot closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M4rtinK M4rtinK M4rtinK approved these changes

Assignees
No one assigned
Labels
blocked Don't merge this pull request! stale
Milestone
No milestone
3 participants
@rvykydal @pep8speaks @M4rtinK