Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply --noverifyssl option for liveimg kickstart command #4532

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Apply --noverifyssl option for liveimg kickstart command #4532

merged 1 commit into from
Feb 14, 2023

Conversation

jstodola
Copy link
Contributor

Related: rhbz#1886985

@poncovka
Copy link
Contributor

/kickstart-test --testtype smoke

M4rtinK
M4rtinK approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! :)

VladimirSlavik
VladimirSlavik approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me.

(I checked the actual download / source use, and this should be the whole fix.)

@VladimirSlavik VladimirSlavik added the f38 Fedora 38 label Jan 30, 2023
poncovka
poncovka approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkonecny12
Copy link
Member

We are going to backport this to RHEL. So I think we should have here also the unit tests? WDYT @poncovka ?

@poncovka
Copy link
Contributor

poncovka commented Feb 3, 2023

We are going to backport this to RHEL. So I think we should have here also the unit tests? WDYT @poncovka ?

Sure. Why not.

@VladimirSlavik VladimirSlavik added the port to RHEL9 The pull request needs to be ported to RHEL 9. label Feb 3, 2023
@VladimirSlavik
Copy link
Contributor

Normally I'd just merge this, but I can't exactly assign myself since I'm away, and it's acked but we want tests. No idea what to do here.

@jkonecny12
Copy link
Member

@jstodola are you fine with creating also a unit tests or should we handle that for you?

@jstodola
Copy link
Contributor Author

jstodola commented Feb 3, 2023 •
edited
Loading

@jkonecny12 I will give it a try and ask for help if I fail.

@jstodola
Copy link
Contributor Author

A unit test added.

@VladimirSlavik
Copy link
Contributor

/kickstart-test --testtype smoke

VladimirSlavik
VladimirSlavik approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, test LGTM.

@VladimirSlavik VladimirSlavik self-assigned this Feb 13, 2023
poncovka
poncovka approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@poncovka poncovka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@poncovka poncovka merged commit 842155a into rhinstaller:master Feb 14, 2023
@jstodola jstodola mentioned this pull request May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M4rtinK M4rtinK M4rtinK approved these changes

@poncovka poncovka poncovka approved these changes

@VladimirSlavik VladimirSlavik VladimirSlavik approved these changes

Assignees

@VladimirSlavik VladimirSlavik

Labels
f38 Fedora 38 port to RHEL9 The pull request needs to be ported to RHEL 9.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jstodola @poncovka @jkonecny12 @VladimirSlavik @M4rtinK