Delete scheduled tasks after execution #126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The plugin leaves two scheduled tasks behin starting with
packer-windows-update
that might pose a security risk.This was also mentioned in issue #106.
Question
Could this be a suitable fix? Is does not look like the tasks are re-used anywhere so why not delete them as part of the execution. Unfortunately, I don't have a development environment set up for plugin development to test it myself nor do I know Go.
@rgl could you maybe have a quick look at this? Thank you in advance.