Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete scheduled tasks after execution #126

Merged

Conversation

PfurtschellerP
Copy link

Problem

The plugin leaves two scheduled tasks behin starting with packer-windows-update that might pose a security risk.
This was also mentioned in issue #106.

Question

Could this be a suitable fix? Is does not look like the tasks are re-used anywhere so why not delete them as part of the execution. Unfortunately, I don't have a development environment set up for plugin development to test it myself nor do I know Go.
@rgl could you maybe have a quick look at this? Thank you in advance.

@rgl
Copy link
Owner

rgl commented Mar 15, 2023

I've tested it, and it works as expected. You can mark this MR ready for review.

Be aware this also leaves the logs in c:\windows\temp, so you probably also need to add an external provisioning step (outside this plugin) to remove the log files.

@PfurtschellerP PfurtschellerP marked this pull request as ready for review March 16, 2023 07:38
@PfurtschellerP
Copy link
Author

PfurtschellerP commented Mar 16, 2023

@rgl Thank you for your quick response.
Just one last question. Would it be possible to create a new release for this?

@rgl
Copy link
Owner

rgl commented Mar 16, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants