Fix mottled transparent lines #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the weird mottled lines you get whenever you draw transparent with the pen. This also fixes the bug where the click handler draws the last point in a freehand line on mouseup after it's already been drawn on by the mouse-move (the mouse-move to get to the point) - moved on click to on mouseup, and added a checker to make it return if it's already drawn on a point this click (if the user dragged the mouse)
|
@mrfoogles Looks Good, we will review these changes soon. |
|
...it's been two months |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you use the pen tool to draw transparent lines, they end up different colors across, since the pen is drawing multiple times on each pixel.
I added Canvas.previous_pixel so that the pen tool will now only draw once on each pixel until you move the mouse onto another.
Original
broken.mov
Fixed (I meant to use the same color on both, but this one is dark blue)
fixed.mov