Update from upstream #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
of argument number compatibiilty from macro expansion time to runtime.
occur and checks argument cardinality at macro expansion time if not.
…ix travis failure.
…nce with the grisu alogrithm (printing the shortest form that can be read back in accurately).
…risu Conflicts: deps/Makefile
Adds a resultexpr field to Failure and Success.
…risu Conflicts: .travis.yml LICENSE.md Makefile deps/Makefile test/runtests.jl
…risu Conflicts: deps/Makefile
Update pcre to 8.35
Bump FFTW to 3.3.4
RFC: Enable github two-factor authentication; fixes #5252
Add bounds checking to IOBuffer seek, skip code (fixes #8193)
…ds_checking Revert "Add bounds checking to IOBuffer seek, skip code (fixes #8193)"
Fix segfault when code_llvm or code_native are called on a C function
The jlhelp.py code needs to be updated to work with sphinx 1.2, to stop adding extra newlines. Closes #7754.
Add a sentence in the manual on how to redirect stderr
rfourquet
pushed a commit
that referenced
this pull request
May 3, 2017
This changes nprocs (and therefore nworkers) report only workers in `W_CONNECTED` state. This is to avoid issue with `@everywhere` or other similar methods that broadcast messages to all workers. To simulate: - introduce an artificial delay at https://github.com/JuliaLang/julia/blob/2c4f6d74577a1b7606ed5e74e96158810f4f7af4/base/distributed/cluster.jl#L443 with `sleep(10)` - start a master with: ``` using ClusterManagers ElasticManager(;addr=IPv4("0.0.0.0"), port=9009, cookie="cookie", topology=:master_slave) while nworkers() < 4 sleep(1) end @Everywhere println(myid()) ``` - start 4 workers with: ``` using ClusterManagers ClusterManagers.elastic_worker("cookie", "127.0.0.1", 9009; stdout_to_master=false) ``` Without this change, this will often result in: ``` ERROR: LoadError: peer 3 is not connected to 1. Topology : master_slave check_worker_state(::Base.Distributed.Worker) at ./distributed/cluster.jl:115 send_msg_(::Base.Distributed.Worker, ::Base.Distributed.MsgHeader, ::Base.Distributed.CallMsg{:call_fetch}, ::Bool) at ./distributed/messages.jl:180 remotecall_fetch(::Function, ::Base.Distributed.Worker, ::Expr, ::Vararg{Expr,N} where N) at ./distributed/remotecall.jl:346 remotecall_fetch(::Function, ::Int64, ::Expr, ::Vararg{Expr,N} where N) at ./distributed/remotecall.jl:367 (::##1#3)() at ./distributed/macros.jl:84 ```
rfourquet
pushed a commit
that referenced
this pull request
Jul 6, 2018
Merge further performance improvements from @jakebolewski
rfourquet
pushed a commit
that referenced
this pull request
Jul 6, 2018
Add config, unicode/ascii, scroll wrap
rfourquet
pushed a commit
that referenced
this pull request
Oct 3, 2020
This reuses the machinery that gives good stacktraces when a user
calls wait on a Task. Since bind internally uses _wait2, this
machinery is bypassed currently.
Currently, julia throws an uninformative stacktrace in this situation:
julia> c = Channel(_ -> error("foo"))
Channel{Any}(sz_max:0,sz_curr:0)
julia> for i in c end
ERROR: foo
Stacktrace:
[1] iterate(::Channel{Any}) at ./channels.jl:459
[2] top-level scope at ./REPL[2]:1
With this change, the stacktrace is much more informative:
julia> for i in c end
ERROR: TaskFailedException:
foo
Stacktrace:
[1] error(::String) at ./error.jl:33
[2] (::var"#1#2")(::Channel{Any}) at ./REPL[4]:1
[3] (::Base.var"JuliaLang#652#653"{var"#1#2",Channel{Any}})() at ./channels.jl:129
Stacktrace:
[1] check_channel_state at ./channels.jl:167 [inlined]
[2] take_unbuffered(::Channel{Any}) at ./channels.jl:405
[3] take! at ./channels.jl:383 [inlined]
[4] iterate(::Channel{Any}, ::Nothing) at ./channels.jl:449
[5] iterate(::Channel{Any}) at ./channels.jl:448
[6] top-level scope at ./REPL[5]:1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.