Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anonymous/passwordless user access #52

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

amundhov
Copy link

@amundhov amundhov commented Jul 3, 2024

Resubmitting anonymous user PR without type hinting changes.

@rexzhang
Copy link
Owner

rexzhang commented Jul 4, 2024

one issue one PR,PLEASE!

@rexzhang rexzhang marked this pull request as draft July 4, 2024 07:44
@amundhov
Copy link
Author

amundhov commented Jul 4, 2024

Got you. I put the functionality on a separate branch on my fork and couldn't figure out how to change target on the original PR.

Is it possible to delete the old one that was closed and proceed here, please?

@rexzhang
Copy link
Owner

rexzhang commented Jul 4, 2024

Create one branch in your repos for each issue, and then create one PR for each branch. After that, just close the old PR.

@rexzhang
Copy link
Owner

rexzhang commented Jul 4, 2024

BTW:It is recommended to focus on one PR at one time, other PRs can be processed later in Draft status.

@amundhov amundhov changed the title Resubmitted: Anonymous/passwordless user access Anonymous/passwordless user access Jul 25, 2024
@amundhov amundhov marked this pull request as ready for review July 25, 2024 11:50
@rexzhang
Copy link
Owner

You can submit a new commit to remove the irrelevant changes, and then I can "squash and merge", and that's it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants