Add @font-face messed test case and update parsing #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -461,7 +461,7 @@ module.exports = function(css, options){ | |||
|
|
|||
| function atfontface() { | |||
| var pos = position(); | |||
| var m = match(/^@font-face */); | |||
| var m = match(/^@font-face( |\n)*/); | |||
There was a problem hiding this comment.
Couldn't this use \s to select all whitespace?
There was a problem hiding this comment.
Yeah, sorry. I am a bit rusty with my regular expressions. I will fix it up and rebase.
|
Thanks for catching this! It looks like basically all the other |
|
No worries. Yeah, sure thing. Did you use any tools to create the AST files? |
|
I actually did have a small script that generated the AST files when I added them to all the tests, since the code wasn't being changed. When adding new tests they should definitely be reviewed carefully if they are auto-generated. |
conradz
added a commit
that referenced
this pull request
Dec 17, 2014
Add @font-face messed test case and update parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was using a rework based preprocessor, and recently it wouldn't let me place my braces on the next line for the
@font-facerule so I have updated the parsing with an accompanying test case.