Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge repositories.tag and repositories.sha fields #74

Closed
0xDEC0DE opened this issue Dec 25, 2023 · 0 comments · Fixed by #78
Closed

Merge repositories.tag and repositories.sha fields #74

0xDEC0DE opened this issue Dec 25, 2023 · 0 comments · Fixed by #78

Comments

@0xDEC0DE
Copy link
Contributor

Commit d306437 made the handling of these two fields 100% equivalent, so they should be deprecated and combined into a repositories.version field, or similar.

retr0h added a commit that referenced this issue Dec 27, 2023
Commit d306437 made the handling of
these two fields 100% equivalent.

Breaking change will need to migrate `Giltfile.yaml`
`repositories.tag` and/or `repositories.sha` to `repositories.version`

From:

```yaml
repositories:
  - git: https://github.com/retr0h/ansible-etcd.git
    sha: 77a95b7
    dstDir: /tmp/retr0h.ansible-etcd
  - git: https://github.com/retr0h/ansible-etcd.git
    tag: 1.1
    dstDir: /tmp/retr0h.ansible-etcd
```

To:

```yaml
repositories:
  - git: https://github.com/retr0h/ansible-etcd.git
    version: 77a95b7
    dstDir: /tmp/retr0h.ansible-etcd
  - git: https://github.com/retr0h/ansible-etcd.git
    version: 1.1
    dstDir: /tmp/retr0h.ansible-etcd
```

Fixes: #74
retr0h added a commit that referenced this issue Dec 27, 2023
Commit d306437 made the handling of
these two fields 100% equivalent.

Breaking change will need to migrate `Giltfile.yaml`
`repositories.tag` and/or `repositories.sha` to `repositories.version`

From:

```yaml
repositories:
  - git: https://github.com/retr0h/ansible-etcd.git
    sha: 77a95b7
    dstDir: /tmp/retr0h.ansible-etcd
  - git: https://github.com/retr0h/ansible-etcd.git
    tag: 1.1
    dstDir: /tmp/retr0h.ansible-etcd
```

To:

```yaml
repositories:
  - git: https://github.com/retr0h/ansible-etcd.git
    version: 77a95b7
    dstDir: /tmp/retr0h.ansible-etcd
  - git: https://github.com/retr0h/ansible-etcd.git
    version: 1.1
    dstDir: /tmp/retr0h.ansible-etcd
```

Fixes: #74
retr0h added a commit that referenced this issue Dec 27, 2023
Commit d306437 made the handling of
these two fields 100% equivalent.

Breaking change will need to migrate `Giltfile.yaml`
`repositories.tag` and/or `repositories.sha` to `repositories.version`

From:

```yaml
repositories:
  - git: https://github.com/retr0h/ansible-etcd.git
    sha: 77a95b7
    dstDir: /tmp/retr0h.ansible-etcd
  - git: https://github.com/retr0h/ansible-etcd.git
    tag: 1.1
    dstDir: /tmp/retr0h.ansible-etcd
```

To:

```yaml
repositories:
  - git: https://github.com/retr0h/ansible-etcd.git
    version: 77a95b7
    dstDir: /tmp/retr0h.ansible-etcd
  - git: https://github.com/retr0h/ansible-etcd.git
    version: 1.1
    dstDir: /tmp/retr0h.ansible-etcd
```

Fixes: #74
retr0h added a commit that referenced this issue Dec 27, 2023
Commit d306437 made the handling of
these two fields 100% equivalent.

Breaking change will need to migrate `Giltfile.yaml`
`repositories.tag` and/or `repositories.sha` to `repositories.version`

From:

```yaml
repositories:
  - git: https://github.com/retr0h/ansible-etcd.git
    sha: 77a95b7
    dstDir: /tmp/retr0h.ansible-etcd
  - git: https://github.com/retr0h/ansible-etcd.git
    tag: 1.1
    dstDir: /tmp/retr0h.ansible-etcd
```

To:

```yaml
repositories:
  - git: https://github.com/retr0h/ansible-etcd.git
    version: 77a95b7
    dstDir: /tmp/retr0h.ansible-etcd
  - git: https://github.com/retr0h/ansible-etcd.git
    version: 1.1
    dstDir: /tmp/retr0h.ansible-etcd
```

Fixes: #74
retr0h added a commit that referenced this issue Dec 27, 2023
Commit d306437 made the handling of
these two fields 100% equivalent.

Breaking change will need to migrate `Giltfile.yaml`
`repositories.tag` and/or `repositories.sha` to `repositories.version`

From:

```yaml
repositories:
  - git: https://github.com/retr0h/ansible-etcd.git
    sha: 77a95b7
    dstDir: /tmp/retr0h.ansible-etcd
  - git: https://github.com/retr0h/ansible-etcd.git
    tag: 1.1
    dstDir: /tmp/retr0h.ansible-etcd
```

To:

```yaml
repositories:
  - git: https://github.com/retr0h/ansible-etcd.git
    version: 77a95b7
    dstDir: /tmp/retr0h.ansible-etcd
  - git: https://github.com/retr0h/ansible-etcd.git
    version: 1.1
    dstDir: /tmp/retr0h.ansible-etcd
```

Fixes: #74
retr0h added a commit that referenced this issue Dec 29, 2023
Commit d306437 made the handling of
these two fields 100% equivalent.

Breaking change will need to migrate `Giltfile.yaml`
`repositories.tag` and/or `repositories.sha` to `repositories.version`

From:

```yaml
repositories:
  - git: https://github.com/retr0h/ansible-etcd.git
    sha: 77a95b7
    dstDir: /tmp/retr0h.ansible-etcd
  - git: https://github.com/retr0h/ansible-etcd.git
    tag: 1.1
    dstDir: /tmp/retr0h.ansible-etcd-tag
```

To:

```yaml
repositories:
  - git: https://github.com/retr0h/ansible-etcd.git
    version: 77a95b7
    dstDir: /tmp/retr0h.ansible-etcd
  - git: https://github.com/retr0h/ansible-etcd.git
    version: 1.1
    dstDir: /tmp/retr0h.ansible-etcd
```

Fixes: #74
retr0h added a commit that referenced this issue Dec 29, 2023
Commit d306437 made the handling of
these two fields 100% equivalent.

Breaking change will need to migrate `Giltfile.yaml`
`repositories.tag` and/or `repositories.sha` to `repositories.version`

From:

```yaml
repositories:
  - git: https://github.com/retr0h/ansible-etcd.git
    sha: 77a95b7
    dstDir: /tmp/retr0h.ansible-etcd
  - git: https://github.com/retr0h/ansible-etcd.git
    tag: 1.1
    dstDir: /tmp/retr0h.ansible-etcd-tag
```

To:

```yaml
repositories:
  - git: https://github.com/retr0h/ansible-etcd.git
    version: 77a95b7
    dstDir: /tmp/retr0h.ansible-etcd
  - git: https://github.com/retr0h/ansible-etcd.git
    version: 1.1
    dstDir: /tmp/retr0h.ansible-etcd
```

Fixes: #74
retr0h added a commit that referenced this issue Dec 29, 2023
Commit d306437 made the handling of
these two fields 100% equivalent.

Breaking change will need to migrate `Giltfile.yaml`
`repositories.tag` and/or `repositories.sha` to `repositories.version`

From:

```yaml
repositories:
  - git: https://github.com/retr0h/ansible-etcd.git
    sha: 77a95b7
    dstDir: /tmp/retr0h.ansible-etcd
  - git: https://github.com/retr0h/ansible-etcd.git
    tag: 1.1
    dstDir: /tmp/retr0h.ansible-etcd-tag
```

To:

```yaml
repositories:
  - git: https://github.com/retr0h/ansible-etcd.git
    version: 77a95b7
    dstDir: /tmp/retr0h.ansible-etcd
  - git: https://github.com/retr0h/ansible-etcd.git
    version: 1.1
    dstDir: /tmp/retr0h.ansible-etcd
```

Fixes: #74
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant