Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get config file validation under test #106

Closed
0xDEC0DE opened this issue Jan 1, 2024 · 1 comment
Closed

Get config file validation under test #106

0xDEC0DE opened this issue Jan 1, 2024 · 1 comment

Comments

@0xDEC0DE
Copy link
Contributor

0xDEC0DE commented Jan 1, 2024

This is fairly low-priority, since there's little in the way of custom handling being done, but at least a cursory attempt should be made to ensure that reading config files works as intended.
@retr0h
Copy link
Owner

retr0h commented Jan 2, 2024

There is some basic config file validation with go-playground/validator. Should mostly do what we want.

See:

@0xDEC0DE 0xDEC0DE mentioned this issue Jan 2, 2024
Merged
retr0h pushed a commit that referenced this issue Jan 3, 2024
@nisimond @retr0h
refactor: Get config.Validate() under test
f10b277 
We have an entrypoint for validating the Repositories schema, so
use it when validating, to ensure test coverage.  All the other
tests will use the validator in the test suite.

Fixes: Issue #106
@0xDEC0DE 0xDEC0DE closed this as completed Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@retr0h @0xDEC0DE