Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3: Add warning if key ID or secret is empty #3532

Merged
merged 1 commit into from
Oct 9, 2021

Conversation

garrmcnu
Copy link
Contributor

@garrmcnu garrmcnu commented Sep 30, 2021

What does this PR change? What problem does it solve?

Add warning for S3/GS/Azure if credentials are not set.

Was the change previously discussed in an issue or on the forum?

Closes #2388

Checklist

  • I have read the contribution guidelines.
  • I have enabled maintainer edits.
  • I have added tests for all code changes.
  • I have added documentation for relevant changes (in the manual).
  • There's a new file in changelog/unreleased/ that describes the changes for our users (see template).
  • I have run gofmt on the code in all commits.
  • All commit messages are formatted in the same style as the other commits in the repo.
  • I'm done! This pull request is ready for review.

garrmcnu added a commit to garrmcnu/restic that referenced this pull request Sep 30, 2021
cmd/restic/global.go Outdated Show resolved Hide resolved
cmd/restic/global.go Outdated Show resolved Hide resolved
cmd/restic/global.go Outdated Show resolved Hide resolved
Also add debug message if no credential types are available.

Closes restic#2388
Copy link
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@MichaelEischer MichaelEischer merged commit 58e8b34 into restic:master Oct 9, 2021
@garrmcnu garrmcnu deleted the s3-credentials-config branch October 10, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3: Incomplete credentials (supplied from env) not reported
2 participants