Check: check sizes of packs from index and packheader #3082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greatroar
reviewed
Nov 11, 2020
greatroar
reviewed
Nov 11, 2020
rawtaz
reviewed
Nov 11, 2020
|
I'm very sorry about the broken CI, it should be fixed on master. Can you rebase? |
|
Is now rebased - all test have passed. |
8 tasks
MichaelEischer
approved these changes
Nov 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change? What problem does it solve?
Adds checks to the
checkcommand that the pack file sizes match to the sizes computed by the index and the pack header.Was the change discussed in an issue or in the forum before?
See discussion in #3048
Checklist
gofmton the code in all commits